Rename the SAP JCo connector to SAP ECC (JCo) - #52
Merged
Conversation
Updates the display name override so the store shows the connector's new name. DISPLAY_NAME_OVERRIDES takes highest priority in getDisplayName, ahead of the Name/ keyword, so this entry is what the store actually renders for ballerinax/sap.jco.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Comment |
daneshk
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Renames the connector display name from SAP JCo to SAP ECC (JCo) in the store.
Companion PRs:
Change
src/lib/connector-utils/connector-utils.tsWhy this file
getDisplayName()resolves a connector's name in this order:The override dictionary takes highest priority and, as its comment notes, bypasses all other name resolution.
ballerinax/sap.jcohas an entry there, so the store keeps rendering the overridden value regardless of what the package publishes.The companion connector PR adds a
Name/SAP ECC (JCo)keyword toBallerina.toml, which is step 2 of the same resolution order. That alone would not change the store while this override exists, so both are needed: this entry is what the store renders today, and the keyword keeps the name correct if the override is ever removed.Scope
One line. The package name
sap.jcois unchanged, so the map key, the connector's docs URL, and the store route are untouched.