Skip to content

Rename the SAP JCo connector to SAP ECC (JCo) - #52

Merged
daneshk merged 1 commit into
mainfrom
rename-sap-jco-to-sap-ecc-jco
Sep 8, 2026
Merged

Rename the SAP JCo connector to SAP ECC (JCo)#52
daneshk merged 1 commit into
mainfrom
rename-sap-jco-to-sap-ecc-jco

Conversation

@RDPerera

@RDPerera RDPerera commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Purpose

Renames the connector display name from SAP JCo to SAP ECC (JCo) in the store.

Companion PRs:

Change

src/lib/connector-utils/connector-utils.ts

-  'sap.jco': 'SAP JCo',
+  'sap.jco': 'SAP ECC (JCo)',

Why this file

getDisplayName() resolves a connector's name in this order:

1. DISPLAY_NAME_OVERRIDES   (full package name match)
2. Name/ keyword from Ballerina.toml
3. Smart capitalization
4. Vendor metadata
5. Default

The override dictionary takes highest priority and, as its comment notes, bypasses all other name resolution. ballerinax/sap.jco has an entry there, so the store keeps rendering the overridden value regardless of what the package publishes.

The companion connector PR adds a Name/SAP ECC (JCo) keyword to Ballerina.toml, which is step 2 of the same resolution order. That alone would not change the store while this override exists, so both are needed: this entry is what the store renders today, and the keyword keeps the name correct if the override is ever removed.

Scope

One line. The package name sap.jco is unchanged, so the map key, the connector's docs URL, and the store route are untouched.

Updates the display name override so the store shows the connector's
new name. DISPLAY_NAME_OVERRIDES takes highest priority in
getDisplayName, ahead of the Name/ keyword, so this entry is what the
store actually renders for ballerinax/sap.jco.
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 86d10a67-feea-4185-91c8-d9c1e2cc0770


Comment @coderabbitai help to get the list of available commands.

@daneshk
daneshk merged commit ed2d36d into main Sep 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants