Migrate to Swift 5 and iOS 13 #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove 'public' method access control modifier - Change constants retreival - Change swift version number
This needs to be fullScreen to trigger viewWillAppear in splash vc
- Change Xcode and Swift version note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the Xcode project to Swift 5.0, one of two major versions of Swift supported by Xcode 11, and is needed to make the project compile and run if downloaded (fixes #5).
This PR also sets the modal presentation style of the new order coordinator's root controller to
fullScreenwhich is needed to triggerviewWillAppearof the underlaying splash view controller, which in turn updates the total number of orders. This is because the default modal presentation style changed in iOS 13 topageSheet(fixes #6).Finally it updates the readme to accurately reflect the required Xcode and Swift versions