Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite using new Aperture and n-api #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

karaggeorge
Copy link
Member

@karaggeorge karaggeorge commented Nov 11, 2024

Implements the changes in wulkano/Aperture#80

  • Adds support for the new APIs
  • Allows multiple recorders to be running at the same time
  • Adapts the TS types to support multiple recording types
  • Adds a Node add-on target (using node-swift)
  • Adds a native.js export that uses that add-on

For now, kept the other as the default, since the add-on can't be cross-platform compiled until this is released

@karaggeorge
Copy link
Member Author

karaggeorge commented Nov 13, 2024

@sindresorhus Any idea why when I ran this with the macos-14 image I got errors for missing properties. They are marked with if #avalable(macOS 15) 🤔

Building with macos-15 worked, but failed the tests. I got those failures intermittently locally too, still not sure why they happen. It only happens for the CLI, I think something to do with the way I use async with the run loop. I'll debug a bit more tonight

I didn't have any such issues using the aperture.node bindings, but I couldn't get rid of the CLI since I can't build it cross-platform

Could we do something similar to Kap, run the build in two workers one for arm and one for intel, generate two .node files and require them conditionally at runtime?

Or is there value in keeping the CLI version in general

)
],
dependencies: [
.package(url: "https://github.com/wulkano/Aperture", from: "2.0.1"),
.package(url: "https://github.com/apple/swift-argument-parser", from: "1.3.1")
.package(url: "https://github.com/wulkano/Aperture", branch: "george/rewrite-in-screen-capture-kit"),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch here should change back to the real version when the Aperture PR is merged/released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant