Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone call from specified sim slot #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kukadiajayesh
Copy link
Contributor

-For dual sim phone
-Updated compileSDKVersion to 25

-Updated compileSDKVersion to 25
@wumke
Copy link
Owner

wumke commented Jan 8, 2019

Nice feature to add, I did not use 2 sim phones yet so would never ran into this need myself.

I gave it a quick look and will not merge it as-is because the iOS part is not updated, and the default value should not need to be set manually but be optional with a 'real default value' of 0 instead (or should we ask the user which one to use when no value is provided? or just provide a getter so users can manage their preferences themselves?).
The readme should also specify that this only works for Android at the moment, or the iOS implementation should be included (I only have single sim apple devices)

If I find some time I will try to look how ios handles the 2 sim devices, but since I'm very busy at the moment I won't expect this to be the coming month... If anyone want to contribute, feel free and share your progress in this thread!

@MustaMohamed
Copy link

@wumke Please could you check this ASAP, I'm working on an app to use call and I need this feature.
So, could you please check this ASAP ?!

@wumke
Copy link
Owner

wumke commented Jul 29, 2019

I have no time to add and test this feature myself... but you can update this pull request with things I mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants