chore(rfc): Extend core module system to support metrics #1130
Conversation
kaialang
force-pushed
the
extend_core_module_for_metrics
branch
2 times, most recently
from
eda719a
to
0efb9d1
Compare
StarpTech
changed the title
kaialang
force-pushed
the
extend_core_module_for_metrics
branch
from
0efb9d1
to
d091eab
Compare
kaialang
force-pushed
the
extend_core_module_for_metrics
branch
from
d091eab
to
d083bff
Compare
| @@ -235,21 +251,6 @@ type ApplicationErrorHook interface { | |||
| OnAppError(err error) | |||
| } | |||
|
|
|||
| // TelemetryHooks are called when a span is created | |||
There was a problem hiding this comment.
👍 I wasn't a fan of it either. I think we can solve this with generic hooks and let the developer decide what to do at this time.
| } | ||
|
|
||
| type GraphQLOperationPlanHook interface { | ||
| // OnPlan is called when an operation is planned | ||
| type GraphQLOperationPostNormalizeHook interface { |
There was a problem hiding this comment.
I like the pre/post capabilities.
| return nil | ||
| } | ||
|
|
||
| func (m *MyModule) OnRouterResponse(res *core.RouterResponse, err error) error { |
There was a problem hiding this comment.
The use case would be covered but I'm still not happy how data is shared across hooks. I think it can become cumbersome, if you have to use the context api. It would be great to have an API to hook into pre/post without the need to share data.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Motivation and Context
It extends the open core module system RFC to enable custom metric modules.
New findings need to be discussed:
Added one example use case.
TODO