fix: delete graphs before deleting org #1326
Open
+6,989
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
October 31, 2024 10:24
Pull request was closed
thisisnithin
changed the title
thisisnithin
force-pushed
the
nithin/eng-5878-fix-federated-graph-schema-version-relation
branch
from
8bbaa60
to
862d419
Compare
StarpTech
requested changes
Nov 11, 2024
| limit: 0, | ||
| offset: 0, | ||
| }); | ||
| const subgraphs = await subgraphRepo.list({ |
There was a problem hiding this comment.
Is it really necessary? Can't we delete all targets of the org?
| keycloakClient, | ||
| keycloakRealm: realm, | ||
| }, | ||
| blobStorage, |
There was a problem hiding this comment.
Any reason why is this service dependency not part of he UserRepository constructor?
| } = getConfig(); | ||
|
|
||
| const userId = process.env.USER_ID || ''; | ||
|
|
||
| const bucketName = extractS3BucketName(s3Storage); |
There was a problem hiding this comment.
Is it really necessary to put all the logic in here? Why don't we issue a job to the queue and the controlplane picks it up? In that way, we also leverage all benefits that the queue provides retry, history etc...
| return this.db.transaction(async (tx) => { | ||
| const oidcRepo = new OidcRepository(tx); | ||
| const fedGraphRepo = new FederatedGraphRepository(this.logger, tx, organizationId); |
There was a problem hiding this comment.
If we go this road of deleting everything manuel, we need very good tests. Could you outline what is delete by constraints and what not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Checklist