feat(router): make header matching rules case insensitive #1584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Many users have found themselves in confusing places when they've tried to apply our header propagation rules, because they neglected to use the case insensitive prefix to the regex.
HTTP Header names are by RFC case insensitive, so there should be no need to explicitly declare them as case insensitive.
Any case where we were using the
<header>.Get(HEADER)
was by its nature case insensitive, but this specifically needed to fix the header matching rulesChecklist