Update .dockerignore files #454
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ockerignore files in order to trigger image rebuilds when those files change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request makes a minor update to the .dockerignore files for the Silta project. The change removes the exclusion of Silta Dockerfile and Dockerfile.dockerignore patterns, which may affect which files are ignored during Docker builds.
Testing
Instructions:
Create a and deploy new branch from main
Edit silta/php.Dockerfile by adding an arbitrary comment
Deploy the branch again, you'll notice from the CircleCi build job that the php image did not get rebuilt
Do the same thing but make the new branch from this feature branch
You'll notice that the php image did get rebuilt