Add explicit executable and loader_url for JSDOS/Ruffle - #19
Merged
Conversation
JSDOS and Ruffle sections now require explicit `executable` and optional `loader_url` instead of `entrypoint`. The CLI validates these files exist in upload_dir and passes them as entrypointParams to the backend. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
Haven't tested but looks good to me |
calvinstudebaker
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
executable(e.g.game.jsdos,game.swf) and accept optionalloader_url(custom loader script) instead of the previousentrypointfieldupload_dirbefore uploadingentrypointParams(withexecutable+loaderUrl) directly to the backend, so the backend no longer needs to auto-discover.jsdos/.swffiles during post-upload processingTest plan
executableandloader_urlset in TOMLexecutableset (noloader_url)executablefile doesn't exist inupload_dir🤖 Generated with Claude Code