fix(paywall): use token name from payment requirements instead of hardcoded USDC#1988
Closed
Ai-chan-0411 wants to merge 1 commit intox402-foundation:mainfrom
Closed
fix(paywall): use token name from payment requirements instead of hardcoded USDC#1988Ai-chan-0411 wants to merge 1 commit intox402-foundation:mainfrom
Ai-chan-0411 wants to merge 1 commit intox402-foundation:mainfrom
Conversation
…dcoded USDC Read the token name from firstRequirement.extra.name and fall back to "USDC" when the field is absent. This fixes incorrect labels for non-USDC tokens like MegaUSD and USDT0. Closes x402-foundation#1972
|
@aoi-dev-0411 is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Duplicate of #1973 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The EVM paywall currently hardcodes "USDC" as the token label in all user-facing strings. This is incorrect for chains whose default stablecoin is not named USDC (e.g. MegaETH uses MegaUSD, Stable uses USDT0).
This PR reads the token name from
firstRequirement.extra.name(set by the server from the default asset registry) and falls back to "USDC" when the field is absent, maintaining backward compatibility.Changes
tokenNamefromfirstRequirement.extra.namewith"USDC"fallback"USDC"display strings inEvmPaywall.tsx:Testing
extra.nameis"USDC", behavior is identical to beforeextra.nameis"MegaUSD", paywall now correctly shows "MegaUSD" instead of "USDC"extra.nameis absent: falls back to "USDC" (backward compatible)Closes #1972