Skip to content

chore: improve ocpp 1.6 testing#79

Open
xBlaz3kx wants to merge 1 commit into
chore/restructure-testsfrom
chore/restructure-tests-ocpp-16
Open

chore: improve ocpp 1.6 testing#79
xBlaz3kx wants to merge 1 commit into
chore/restructure-testsfrom
chore/restructure-tests-ocpp-16

Conversation

@xBlaz3kx

@xBlaz3kx xBlaz3kx commented Apr 26, 2026

Copy link
Copy Markdown
Owner

Proposed changes

  • Moved/nested validation tests in ocpp 1.6 subpackages
  • Additional OCPP request/response constructor tests

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 24960795277

Coverage decreased (-1.6%) to 81.716%

Details

  • Coverage decreased (-1.6%) from the base build.
  • Patch coverage: 7 uncovered changes across 1 file (3 of 10 lines covered, 30.0%).
  • 130 coverage regressions across 26 files.

Uncovered Changes

File Changed Covered %
ocpp1.6/types/security_extension.go 10 3 30.0%

Coverage Regressions

130 previously-covered lines in 26 files lost coverage.

Top 10 Files by Coverage Loss Lines Losing Coverage Coverage
ocpp1.6/types/types.go 54 48.28%
ocpp1.6/types/datetime.go 9 61.9%
ocpp1.6/core/stop_transaction.go 7 77.42%
ocpp1.6/types/security_extension.go 6 52.94%
ocpp1.6/core/change_availability.go 4 89.74%
ocpp1.6/core/reset.go 4 89.74%
ocpp1.6/core/status_notification.go 4 89.74%
ocpp1.6/localauth/send_local_list.go 4 90.0%
ocpp1.6/remotetrigger/trigger_message.go 4 89.74%
ocpp1.6/certificates/delete_certificate.go 2 93.55%

Coverage Stats

Coverage Status
Relevant Lines: 8253
Covered Lines: 6744
Line Coverage: 81.72%
Coverage Strength: 11.87 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants