Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create binding for Square.Otto #1290

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

syedhoque89
Copy link

@syedhoque89 syedhoque89 commented Oct 17, 2021

Xamarin Android binding for Square.Otto. Not adding sample as the original package is obsolete and no longer mantained. This is more like a runtime dependency solver rather a feature package.

Copy link
Collaborator

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good.

It also needs to be added to the manifest to build:
https://github.com/xamarin/XamarinComponents/blob/main/manifest.yaml#L330-L334

@syedhoque89 syedhoque89 marked this pull request as ready for review October 18, 2021 06:46
@syedhoque89
Copy link
Author

@mattleibow Updated! 🤡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants