-
Notifications
You must be signed in to change notification settings - Fork 3
support pixi environments #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I believe with this we should have a working version (it's still far from where I'd like it to be regarding tests, but this is already much better than before). I'll keep this open for a couple of days to double check there's nothing wrong with it and will then merge and release. |
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do some more testing later
|
|
||
|
|
||
| def parse_spec(name, version_text): | ||
| # "*" => None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been testing with the xarray manifest, and all the minimum envs there have the 'test' feature, which has
array-api-strict = "<2.4"
as a dep, but this errors with
ValueError: Unknown version format: <2.4
since this function doesn't support "<" as a specifier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I realised that the env I was looking at was the wrong one (test-py311-bare-min-and-scipy when it should be test-py311-min-versions - the latter which has array-api-strict pinned to something else). So I don't think this is a problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it actually is a problem (but not with this action, see below): array-api-strict comes from the test feature and is included in test-py311-bare-minimum, which we definitely want to check.
However, I would argue that array-api-strict is not part of the test deps (like pytest or hypothesis), but rather a dependency that should be part of the extras feature. Which means the pin would not be included in the min versions envs, side-stepping this issue.
|
Finished the testing I wanted to do with the xarray manifest - didn't run into any more issues (except those listed above) :) |
This adds initial support for
pixienvironments.It does so by manually parsing the manifest file (which needs to be passed explicitly to the action), extracting the features from the given environment (the name of the env is passed as
pixi:<env-name>) and merging them into a single list of pins.There's still a lot to be done before it can be merged:
PyPI dependencies are ignored without warningwarns nowcc @VeckoTheGecko