-
Notifications
You must be signed in to change notification settings - Fork 101
doc(XCP-ng): Add mention of Viridian extensions #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Instead of pointing to the XO docs, I'd prefer stating that Viridian enlightenments are enabled by default on Windows VM templates included with XCP-ng, as well as having instructions on how to enable/disable Viridian with |
@dinhngtu maybe it should be interested to explain in XCP-ng doc the other platform args [1] needed for Windows VMs? Even if the base template set them. Don't you think? [1] "device_id": "0002",
"viridian": "true",
"viridian_time_ref_count": "true",
"viridian_reference_tsc": "true",
"viridian_apic_assist": "true",
"viridian_crash_ctl": "true",
"viridian_stimer": "true", |
An explanation of For the individual Viridian settings, IMO they're only needed for completeness. The settings correspond to the docs here https://xenbits.xen.org/docs/unstable/man/xl.cfg.5.html#Support-for-Paravirtualisation-of-HVM-Guests (but note that many of the upstream settings are not supported in XCP-ng) |
284b4d2
to
39c358f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks good to me. Just a couple changes:
Mention the importance of Viridian extensions for Windows VMs and explain how to enable Viridian for templates not based off the built-in Windows templates Signed-off-by: Thomas Moraine <[email protected]>
39c358f
to
de22eae
Compare
Following the documentation of Viridian extensions in the Xen Orchestra documentation (see this PR), this PR adds a brief mention of Viridian in the XCP-ng documentation. Additionally, a link to the Viridian section of the XO technical documentation is included for users who want to learn more.