Skip to content

Conversation

Vagrantin
Copy link

@Vagrantin Vagrantin commented Aug 19, 2025

Added more details on the way to access XO-lite Web UI. Also included a warning about the self-signed certificate.

Before submitting the pull request, you must agree with the following statements by checking both boxes with a 'x'.

  • "I accept that my contribution is placed under the CC BY-SA 2.0 license [1]."
  • "My contribution complies with the Developer Certificate of Origin [2]."

[1] https://creativecommons.org/licenses/by-sa/2.0/
[2] https://docs.xcp-ng.org/project/contributing/#developer-certificate-of-origin-dco

Added more details on the way to access XO-lite Web UI.
Also included a warning about the self-signed certificate.

Signed-off-by: MatthDuc <[email protected]>
@stormi stormi requested a review from thomas-dkmt August 25, 2025 17:22
@stormi
Copy link
Member

stormi commented Aug 25, 2025

@Vagrantin Thanks for your contribution. Please check the boxes you left unchecked in the description, and ideally use a real e-mail address for the Signed-off-by field.

Co-authored-by: Thomas Moraine <[email protected]>
Signed-off-by: MatthDuc <[email protected]>
@Vagrantin
Copy link
Author

Thanks for the corrections !
All good for me.

@Vagrantin Vagrantin closed this Sep 1, 2025
@stormi
Copy link
Member

stormi commented Sep 2, 2025

Was this PR mistakingly closed, @Vagrantin? We haven't merged anything yet.

@Vagrantin
Copy link
Author

Was this PR mistakingly closed, @Vagrantin? We haven't merged anything yet.

Yes, my mistake sorry about that not used to the github PR workflow, i thought i had to close it.

@stormi stormi reopened this Sep 2, 2025
@stormi
Copy link
Member

stormi commented Sep 2, 2025

Ping @thomas-dkmt for re-review.

@Vagrantin
Copy link
Author

Thank you guys, again sorry for the mistake.
From here should I do anything else ?
With kind regards.

@stormi
Copy link
Member

stormi commented Sep 4, 2025

@Vagrantin Yes, Thomas asked for several fixes after your last commit.

Vagrantin and others added 5 commits September 4, 2025 22:03
Co-authored-by: Thomas Moraine <[email protected]>
Signed-off-by: MatthDuc <[email protected]>
Co-authored-by: Thomas Moraine <[email protected]>
Signed-off-by: MatthDuc <[email protected]>
Co-authored-by: Thomas Moraine <[email protected]>
Signed-off-by: MatthDuc <[email protected]>
Co-authored-by: Thomas Moraine <[email protected]>
Signed-off-by: MatthDuc <[email protected]>
Co-authored-by: Thomas Moraine <[email protected]>
Signed-off-by: MatthDuc <[email protected]>
@Vagrantin
Copy link
Author

Ok, I have signed off and committed suggestion as everything looks good to me.
Hopefully this is the right thing to do.

Comment on lines +9 to +11
For example:
if my XCP-ng machine has the DNS hostname `mycloud.local`, I will access XO-lite at https://mycloud.local.
if my XCP-ng machine has the IP `192.168.0.1`, I will access XO-lite at https://192.168.0.1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You likely missed Thomas' previous on changing if to If. I also suggest adding dashes to make them bullet points.

Suggested change
For example:
if my XCP-ng machine has the DNS hostname `mycloud.local`, I will access XO-lite at https://mycloud.local.
if my XCP-ng machine has the IP `192.168.0.1`, I will access XO-lite at https://192.168.0.1.
For example:
- If my XCP-ng machine has the DNS hostname `mycloud.local`, I will access XO-lite at https://mycloud.local.
- If my XCP-ng machine has the IP `192.168.0.1`, I will access XO-lite at https://192.168.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants