-
Notifications
You must be signed in to change notification settings - Fork 108
Update xo-lite.md #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update xo-lite.md #382
Conversation
Added more details on the way to access XO-lite Web UI. Also included a warning about the self-signed certificate. Signed-off-by: MatthDuc <[email protected]>
@Vagrantin Thanks for your contribution. Please check the boxes you left unchecked in the description, and ideally use a real e-mail address for the Signed-off-by field. |
Co-authored-by: Thomas Moraine <[email protected]> Signed-off-by: MatthDuc <[email protected]>
Thanks for the corrections ! |
Was this PR mistakingly closed, @Vagrantin? We haven't merged anything yet. |
Yes, my mistake sorry about that not used to the github PR workflow, i thought i had to close it. |
Ping @thomas-dkmt for re-review. |
Thank you guys, again sorry for the mistake. |
@Vagrantin Yes, Thomas asked for several fixes after your last commit. |
Co-authored-by: Thomas Moraine <[email protected]> Signed-off-by: MatthDuc <[email protected]>
Co-authored-by: Thomas Moraine <[email protected]> Signed-off-by: MatthDuc <[email protected]>
Co-authored-by: Thomas Moraine <[email protected]> Signed-off-by: MatthDuc <[email protected]>
Co-authored-by: Thomas Moraine <[email protected]> Signed-off-by: MatthDuc <[email protected]>
Co-authored-by: Thomas Moraine <[email protected]> Signed-off-by: MatthDuc <[email protected]>
Ok, I have signed off and committed suggestion as everything looks good to me. |
For example: | ||
if my XCP-ng machine has the DNS hostname `mycloud.local`, I will access XO-lite at https://mycloud.local. | ||
if my XCP-ng machine has the IP `192.168.0.1`, I will access XO-lite at https://192.168.0.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You likely missed Thomas' previous on changing if
to If
. I also suggest adding dashes to make them bullet points.
For example: | |
if my XCP-ng machine has the DNS hostname `mycloud.local`, I will access XO-lite at https://mycloud.local. | |
if my XCP-ng machine has the IP `192.168.0.1`, I will access XO-lite at https://192.168.0.1. | |
For example: | |
- If my XCP-ng machine has the DNS hostname `mycloud.local`, I will access XO-lite at https://mycloud.local. | |
- If my XCP-ng machine has the IP `192.168.0.1`, I will access XO-lite at https://192.168.0.1. |
Added more details on the way to access XO-lite Web UI. Also included a warning about the self-signed certificate.