Replace manual process handling by local_cmd()

[guzu]

No description provided.

[guzu]

I didn't manage to test everything because I don't know yet how to setup some tests.

[stormi]

I didn't manage to test everything because I don't know yet how to setup some tests.

Can you list the ones you could test and the ones you couldn't? We could likely either help you run the remaining ones, or have them run on the CI hosts from your branch.

[guzu]

Can you list the ones you could test and the ones you couldn't? We could likely either help you run the remaining ones, or have them run on the CI hosts from your branch.

Sure, I did:

• tests/network/test_vif_allowed_ip.py
• tests/storage/ext/test_ext_sr.py : mostly to test reboot()
• tests/xapi_plugins/plugin_netdata/test_netdata.py

I think we need to test the following:

• scripts/install_xcpng.py: which is not a test but is using lots of lib functions used also by the tests
• tests/xo/test_xo_connection.py : I didn't manage to register xo-cli register
• tests/fs_diff/test_fs_diff.py

[stormi]

Ok, so the first one and the third one are not covered by the main CI runs, they're in installation/upgrade tests that @ydirson is much knowledgeable about.

The test_xo_connection.py one, it would be good to make it work. It can be useful to have a local xo-cli and to connect to a XO instance.

[guzu]

Update:

• test_xo_connection.py is working fine with @stormi VM, not mine for unknown reason yet, at least the test is not broken
• no news for other tests

[ydirson]

I think we need to test the following:

* `scripts/install_xcpng.py`: which is not a test but is using lots of lib functions used also by the tests

You should be able to use it to launch an automated install of a nested host

* `tests/fs_diff/test_fs_diff.py`

This one requires 2 hosts to be compared, it should be possible to run using any 2 nested hosts (eg. the one you installed by hand, and one installed with scripts/install_xcpng.py

[ydirson]

yes, a reusable func in netutils for this, and one for ping, look like a good idea

[ydirson]

This looks like more of a commit-level remark than a code-level one, maybe this particular func gets enough treatment that it warrants a separate commit, and this note could move to commit message?