Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toniof 488 cubeconv #493

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Toniof 488 cubeconv #493

wants to merge 7 commits into from

Conversation

TonioF
Copy link
Contributor

@TonioF TonioF commented Jul 28, 2021

Addresses #488 . A new document cubeconv.md replaces the old one cubespec.md.
A new module treatascube.py with methods split_cube and merge_cube has been implemented; these methods have been used to replace assert_cube.py in the instances where it has been used.
(On a side note, in most cases it was enough to use split_cube).

Remaining issues:

  • split_cube internally calls normalize, but without normalizing it to use lat and lon. This does not happen because the dataset would thereby changed in a way that it cannot be safely converted back.
  • For the method resample_in_time in temporal.py it is not enough to use split_cube and merge_cube, as temporarily removed variables might also carry a time dimension. However, this case will not occur often.
  • For the method compute_dataset in compute.py, it is still necessary to implement that all datasets are first resampled to a common CRS.

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

Remember to close associated issues after merge!

Sorry, something went wrong.

@TonioF TonioF requested review from forman and AliceBalfanz July 28, 2021 14:35
@TonioF TonioF self-assigned this Jul 28, 2021
@TonioF TonioF marked this pull request as ready for review July 30, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant