Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #488 . A new document
cubeconv.md
replaces the old onecubespec.md
.A new module
treatascube.py
with methodssplit_cube
andmerge_cube
has been implemented; these methods have been used to replaceassert_cube.py
in the instances where it has been used.(On a side note, in most cases it was enough to use split_cube).
Remaining issues:
split_cube
internally calls normalize, but without normalizing it to uselat
andlon
. This does not happen because the dataset would thereby changed in a way that it cannot be safely converted back.resample_in_time
intemporal.py
it is not enough to use split_cube and merge_cube, as temporarily removed variables might also carry a time dimension. However, this case will not occur often.compute_dataset
in compute.py, it is still necessary to implement that all datasets are first resampled to a common CRS.Checklist:
docs/source/*
CHANGES.md
Remember to close associated issues after merge!