-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xcube WCS #780
Draft
thomasstorm
wants to merge
53
commits into
main
Choose a base branch
from
thomas-716-wcs_dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
xcube WCS #780
+6,651
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 55c433a)
… routes for the endpoints.
Refactored and fixed GET /wcs/kvp operation; Created own WCS config; Closing temp files in context manager; Removed tiles API requirement; Added code comments.
Refactored and fixed GET /wcs/kvp operation; Created own WCS config; Closing temp files in context manager; Removed tiles API requirement; Added code comments.
Expand var label.
# Conflicts: # examples/serve/demo/config-serve2.yml
# Conflicts: # examples/serve/demo/config-serve2.yml
# Conflicts: # examples/serve/demo/config-serve2.yml
…716-wcs_dev # Conflicts: # xcube/webapi/ows/wcs/controllers.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xcube.core.gen2
by Common tile computation #739. This will fix many of the issues listed below as this is a threadsave and scalable approach to fetching data.tiles
API requirementDescribeCoverage
operation.WIDTH
,HEIGHT
andRESX
,RESY
(opt.DEPTH
andRESZ
) that are mandatory ifINTERPOLATION
is not"none"
. Currently, onlyBBOX
is used, sell also displacement in screenshot below.gml:CodeListType
forformats
in capabilities XSD.xcube.webapi.ows.wcs.controllers.CoverageRequest
(as it is no more than a wrapper of the query)Work items done:
config.py
with defaults as code constantskeywords
metadata shall not be mandatoryApiError.BadRequest
if request validation failsGET /wcs/kvp
- is is too long and barely maintainable this waysupportedInterpolations
inDescribeCoverage
operation.TIME
optional as not all datasets have a time dimension.Work item potentially obsolete after (X) has been done.:
datasets_ctx.get_dataset_configs()
is correct only for edge cases (namely, only for filesystem data stores). We must generalize this, i.e., allow for reusing the dataset configurations from xcube server directly in xcube cube generator requests ofxcube.core.gen2
.tiles
API requirementtornado.iostream.StreamClosedError: Stream is closed
issue (likely reason: temporary file removed before Tornado finishes request)history
global attribute not being JSON-serializable (set by xcube Generator)KeyError: Timestamp('2017-01-25 09:35:51')
raised by pandasTypeError: unsupported format string passed to NoneType.__format__
after cube generation (message=f'Cube generated successfully'
)xcube.core.store.error.DataStoreError: Failed to open dataset './demo.conc_chl.zarr': group not found at path ''
Typical QGIS request:
Checklist:
docs/source/*
CHANGES.md