Skip to content

Fix conversion to int #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbrnr merged 2 commits into from
Jun 17, 2026
Merged

Fix conversion to int #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4de57c2
Fix conversion to int
cbrnr Jun 17, 2026
97b6b2e
Add changelog entry
cbrnr Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
## [UNRELEASED] - YYYY-MM-DD
### Fixed
- Fix conversion to `int` for `sample_count` in XDF footer ([#173](https://github.com/xdf-modules/pyxdf/pull/173) by [Clemens Brunner](https://github.com/cbrnr))

## [1.17.5] - 2026-06-15
### Changed
Expand Down
2 changes: 1 addition & 1 deletion src/pyxdf/pyxdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ def _truncate_corrupted_offsets(temp, streams):
sample_count_str = footer.get("sample_count", [None])[0]
if sample_count_str is None:
continue
footer_count = int(sample_count_str)
footer_count = int(float(sample_count_str)) # can be with .0 suffix

if len(stream.time_stamps) <= footer_count:
continue # No extra samples → no evidence of pylsl#67, liblsl#246
Expand Down
Loading