Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use xFuserJointLongContextAttention as the underlying SP method for CogVideoX #280

Merged
merged 10 commits into from
Sep 23, 2024
Merged

fix: use xFuserJointLongContextAttention as the underlying SP method for CogVideoX #280

merged 10 commits into from
Sep 23, 2024

Conversation

xibosun
Copy link
Collaborator

@xibosun xibosun commented Sep 20, 2024

This pr makes the following changes:

  1. Within the xFuserCogVideoXAttnProcessor2_0 class, replace xFuserLongContextAttention with xFuserJointLongContextAttention to perform SP execution correctly.
  2. Fix the forward function in the xFuserJointLongContextAttention class to support various joint_strategies.

@feifeibear feifeibear merged commit fe11de0 into xdit-project:main Sep 23, 2024
3 checks passed
feifeibear pushed a commit to feifeibear/xDiT that referenced this pull request Oct 25, 2024
@xibosun @feifeibear
fix: use xFuserJointLongContextAttention as the underlying SP method …
c680956 
…for CogVideoX (xdit-project#280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feifeibear feifeibear feifeibear approved these changes

@Eigensystem Eigensystem Awaiting requested review from Eigensystem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xibosun @feifeibear