Support building with Emacs 30 #484
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohojo
reviewed
Mar 3, 2025
configure
Outdated
| @@ -97,7 +97,7 @@ check_toolchain() | |||
| EMACS="" | |||
| else | |||
| emacs_version=$($EMACS --version 2>/dev/null | head -n 1) | |||
| if echo $emacs_version | grep -Eq 'GNU Emacs 2[6789]'; then | |||
| if echo $emacs_version | grep -Eq 'GNU Emacs (2[6789]|30)'; then | |||
There was a problem hiding this comment.
Let's make this future-proof - something like 3[0-9] instead of 30
There was a problem hiding this comment.
Is the intent to just support any version newer than 26? Maybe in that case we should just parse the version properly?
There was a problem hiding this comment.
Yeah, basically. Parsing it properly is fine as well :)
There was a problem hiding this comment.
Tried my take at doing a proper(ish) version check.
jian-lin
reviewed
Mar 3, 2025
configure
Outdated
Comment on lines
99
to
101
| emacs_version=$($EMACS --version 2>/dev/null | head -n 1) | ||
| if echo $emacs_version | grep -Eq 'GNU Emacs 2[6789]'; then | ||
| # extract major version from "GNU Emacs [major].[minor]" | ||
| emacs_version=$($EMACS --version 2>/dev/null | head -n 1 | cut -d " " -f 3) | ||
| emacs_major=$(echo "$emacs_version" | cut -d "." -f 1) |
There was a problem hiding this comment.
You can get Emacs major version by printing emacs-major-version.
> emacs -Q --batch --eval='(message "%d" emacs-major-version)'
30There was a problem hiding this comment.
Applied that, and also cleaned up the errors a bit.
Extract the major version and compare it as a number to avoid the messy regexes. Signed-off-by: K900 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.