-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: Add support for typed SSA values in isa #3988
Merged
Merged
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`isa(arg, SSAValue[T])` will check that `arg` is an SSA value, and that its type is `T`. stack-info: PR: #3988, branch: math-fehr/stack/3
94c3082
to
df1b555
Compare
43a5756
to
1c59e49
Compare
This was referenced Feb 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## math-fehr/stack/2 #3988 +/- ##
=====================================================
- Coverage 88.96% 88.96% -0.01%
=====================================================
Files 323 323
Lines 43778 43783 +5
Branches 5440 5442 +2
=====================================================
+ Hits 38947 38950 +3
- Misses 3471 3472 +1
- Partials 1360 1361 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexarice
approved these changes
Feb 28, 2025
1c59e49
to
1f5d2be
Compare
math-fehr
added a commit
that referenced
this pull request
Feb 28, 2025
`isa(arg, SSAValue[T])` will check that `arg` is an SSA value, and that its type is `T`. stack-info: PR: #3988, branch: math-fehr/stack/3
df1b555
to
d825f9f
Compare
math-fehr
added a commit
that referenced
this pull request
Feb 28, 2025
`isa(arg, SSAValue[T])` will check that `arg` is an SSA value, and that its type is `T`. stack-info: PR: #3988, branch: math-fehr/stack/3
compor
approved these changes
Mar 4, 2025
math-fehr
added a commit
that referenced
this pull request
Mar 29, 2025
`isa(arg, SSAValue[T])` will check that `arg` is an SSA value, and that its type is `T`. stack-info: PR: #3988, branch: math-fehr/stack/3
math-fehr
added a commit
that referenced
this pull request
Mar 29, 2025
`isa(arg, SSAValue[T])` will check that `arg` is an SSA value, and that its type is `T`. stack-info: PR: #3988, branch: math-fehr/stack/3
math-fehr
added a commit
that referenced
this pull request
Mar 29, 2025
`isa(arg, SSAValue[T])` will check that `arg` is an SSA value, and that its type is `T`. stack-info: PR: #3988, branch: math-fehr/stack/3
math-fehr
added a commit
that referenced
this pull request
Mar 29, 2025
`isa(arg, SSAValue[T])` will check that `arg` is an SSA value, and that its type is `T`. stack-info: PR: #3988, branch: math-fehr/stack/3
ee2dfdc
to
cd67a58
Compare
aee3a32
to
3f21393
Compare
math-fehr
added a commit
that referenced
this pull request
Mar 29, 2025
`isa(arg, SSAValue[T])` will check that `arg` is an SSA value, and that its type is `T`. stack-info: PR: #3988, branch: math-fehr/stack/3
cd67a58
to
54ce67d
Compare
math-fehr
added a commit
that referenced
this pull request
Mar 29, 2025
`isa(arg, SSAValue[T])` will check that `arg` is an SSA value, and that its type is `T`. stack-info: PR: #3988, branch: math-fehr/stack/3
54ce67d
to
b49c8fd
Compare
f098f2e
to
e8978ae
Compare
math-fehr
added a commit
that referenced
this pull request
Mar 30, 2025
`isa(arg, SSAValue[T])` will check that `arg` is an SSA value, and that its type is `T`. stack-info: PR: #3988, branch: math-fehr/stack/3
b49c8fd
to
b015548
Compare
b015548
to
782955a
Compare
782955a
to
fd27efa
Compare
superlopuh
approved these changes
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
core: Add support for typed SSA values in isa
isa(arg, SSAValue[T])
will check thatarg
is an SSA value, and thatits type is
T
.