bench: pattern rewriting microbenchmarks #4079
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdmundGoodman
requested review from
superlopuh,
compor,
alexarice and
math-fehr
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4079 +/- ##
==========================================
- Coverage 89.05% 89.04% -0.01%
==========================================
Files 318 318
Lines 43407 43405 -2
Branches 5408 5408
==========================================
- Hits 38655 38652 -3
- Misses 3408 3409 +1
Partials 1344 1344 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
superlopuh
reviewed
Mar 19, 2025
superlopuh
reviewed
Mar 19, 2025
|
|
||
| def time_insert_point_before(self) -> None: | ||
| """Time `InsertPoint.before`.""" | ||
| InsertPoint.before(self.add_op) |
superlopuh
approved these changes
Mar 19, 2025
compor
approved these changes
Mar 20, 2025
Comment on lines
+54
to
+56
| WORKLOAD_CONSTANT_20 = parse_module(CTX, WorkloadBuilder.constant_folding(20)) | ||
| WORKLOAD_CONSTANT_100 = parse_module(CTX, WorkloadBuilder.constant_folding(100)) | ||
| WORKLOAD_CONSTANT_1000 = parse_module(CTX, WorkloadBuilder.constant_folding(1_000)) |
There was a problem hiding this comment.
Does this have to be hardcoded here? Can it be dynamic (i.e., configured as such down in main?).
I have the feeling that I've asked about this before, but I might be wrong :)
| integer_type: IntegerType | ||
|
|
||
| def setup(self) -> None: | ||
| """Setup the benchmarks.""" |
There was a problem hiding this comment.
Would you mind adding the sketch for this IR is some sort of pseudocode?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add microbenchmarks for pattern rewriting. Using
pyinstrument, we can get a breakdown of the worst offending functions (shown below, with sections collapsed to highlight the interesting bits)From this, we write a number of microbenchmarks to exercise these bottlenecking functions for pattern rewriting in general and the
RemoveUnusedOperations,CanonicalizationRewritePattern, andregion_dcefunctions of constant folding.Peeled off from tracking PR #4008.