-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialects: (stablehlo) add more operations #4090
dialects: (stablehlo) add more operations #4090
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4090 +/- ##
==========================================
- Coverage 89.05% 89.04% -0.01%
==========================================
Files 319 319
Lines 43413 43469 +56
Branches 5402 5405 +3
==========================================
+ Hits 38660 38707 +47
- Misses 3409 3418 +9
Partials 1344 1344 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
||
For quantized types. performs dequantize_compare(lhs, rhs, comparison_direction) | ||
|
||
https://github.com/openxla/stablehlo/blob/main/docs/spec.md#compare |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/openxla/stablehlo/blob/main/docs/spec.md#compare | |
See [StableHLO Specification](https://github.com/openxla/stablehlo/blob/main/docs/spec.md#compare) |
Nit, but helps with working URLs when publishing our documentation.
Similarly below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 174982d
|
||
For floats: rootn(x, 3) from IEEE-754. | ||
For complex numbers: complex cubic root. | ||
For quantized types: dequantize_op_quantize(cbrt, operand, type(result)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind adding the external spec doc link to this and ceil
below as well please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 174982d
Oh I forgot about docs, but it's a good point, could you please do a pass over the dialect file to make the doc page look nice? Probably worth doing in a separate PR IMO. You can launch the website locally with |
@compor @superlopuh , I will go and make the documentation look good after PR #4092 goes through, sounds good? |
@compor, I don't have merge privileges, hehe :) can you please merge? Thanks! |
This PR adds the following operations:
And the attributes: