feat: 新增 微信客服 - 会话分配与消息收发 fix: 模板卡片参数非必填 若不修改会导致接口报错 #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tttao7
changed the title
xen0n
reviewed
Jan 24, 2024
| @@ -1289,26 +1289,26 @@ const ( | |||
| type TemplateCard struct { | |||
| CardType TemplateCardType `json:"card_type"` | |||
| Source Source `json:"source"` | |||
| ActionMenu ActionMenu `json:"action_menu,omitempty" validate:"required_with=TaskID"` | |||
| ActionMenu *ActionMenu `json:"action_menu,omitempty" validate:"required_with=TaskID"` | |||
There was a problem hiding this comment.
刚发现目前的改法变动了公开类型定义，这应该会导致明确用到了相关字段的下游代码编译错误。
为了不破坏 v1.x 的源码兼容性，可能只能保持这边不动，然后弄一个私有的镜像类型（可以简单命名叫 templateCard 或者别的），在那边把这些字段的类型改了。然后需要在库代码里双向转换：从写作 T 的面向用户的类型转为写作 *T 的内部类型时，先把它跟 T{} 比较，如果是零值的话，那么就保持指针类型的字段为 nil，否则填一个指针；反向操作也差不多。
这样如何？
There was a problem hiding this comment.
哦哦，意思是无论如何，master 分支的用户都必须改是吧？那就不算 API-breaking 了 ;-)
确认下是这样的话我就合并了
There was a problem hiding this comment.
是的 经过测试 如果不传这个值 企业微信那边会报错 xx参数必填 但是实际情况他是选填的 而这个结构体又是刚合并没多久的 或者可以等写这个的小伙伴 @eryajf 回复 json序列化把零值序列进去了
There was a problem hiding this comment.
或者可以等写这个的小伙伴 @eryajf 回复
OK，我等他半天左右（大概明天中午），否则鉴于影响面也小，我就直接合并 ;-)
There was a problem hiding this comment.
我目前没有这块儿的验证场景，所以请根据你们的判断对pr进行处理即可。感谢等待
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: 新增 微信客服 - 会话分配与消息收发 获取会话状态 & 变更会话状态
fix: 模板卡片参数非必填 若不修改会导致接口报错
目前测试下来 当不需要 ActionMenu 时 会发生报错 原因是因为json序列化会默认把默认值放入
@xen0n @eryajf 如果有更好的方案 请指教