Skip to content

fixed scaling on retina display and some deprecated warnings #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KennethLj wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed scaling on retina display and some deprecated warnings #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions Classes/StarRatingControl.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@

#import "StarRatingControl.h"

// return true if the device has a retina display, false otherwise
#define IS_RETINA_DISPLAY() [[UIScreen mainScreen] respondsToSelector:@selector(scale)] && [[UIScreen mainScreen] scale] == 2.0f

// return the scale value based on device's display (2 retina, 1 other)
#define DISPLAY_SCALE IS_RETINA_DISPLAY() ? 2.0f : 1.0f

// Constants :
static const CGFloat kFontSize = 20;
Expand Down Expand Up @@ -166,7 +171,7 @@ - (void)drawRect:(CGRect)rect
else
{
CGContextSetFillColorWithColor(UIGraphicsGetCurrentContext(), _solidColor.CGColor);
[kDefaultSolidChar drawAtPoint:currPoint withFont:[UIFont boldSystemFontOfSize:_starFontSize]];
[kDefaultSolidChar drawAtPoint:currPoint withAttributes:@{NSFontAttributeName:[UIFont boldSystemFontOfSize:_starFontSize]}];
}

currPoint.x += (_starWidthAndHeight + _starSpacing);
Expand All @@ -190,7 +195,7 @@ - (void)drawRect:(CGRect)rect
else
{
CGContextSetFillColorWithColor(UIGraphicsGetCurrentContext(), _emptyColor.CGColor);
[kDefaultEmptyChar drawAtPoint:currPoint withFont:[UIFont boldSystemFontOfSize:_starFontSize]];
[kDefaultEmptyChar drawAtPoint:currPoint withAttributes:@{NSFontAttributeName:[UIFont boldSystemFontOfSize:_starFontSize]}];
}
currPoint.x += (_starWidthAndHeight + _starSpacing);
}
Expand Down Expand Up @@ -434,8 +439,8 @@ - (void)handleTouch:(UITouch *)touch
- (UIImage *) partialImage:(UIImage *)image fraction:(float)fraction
{
CGImageRef imgRef = image.CGImage;
CGImageRef fractionalImgRef = CGImageCreateWithImageInRect(imgRef, CGRectMake(0, 0, image.size.width * fraction, image.size.height));
UIImage *fractionalImg = [UIImage imageWithCGImage:fractionalImgRef];
CGImageRef fractionalImgRef = CGImageCreateWithImageInRect(imgRef, CGRectMake(0, 0, CGImageGetWidth(imgRef) * fraction, CGImageGetHeight(imgRef)));
UIImage *fractionalImg = [UIImage imageWithCGImage:fractionalImgRef scale:DISPLAY_SCALE orientation:UIImageOrientationUp];
CGImageRelease(fractionalImgRef);
return fractionalImg;
}
Expand Down