Skip to content

Zed Agent test implementing multiple content stores#214

Draft
thijslemmens wants to merge 6 commits intomainfrom
contentstore-aggregation
Draft

Zed Agent test implementing multiple content stores#214
thijslemmens wants to merge 6 commits intomainfrom
contentstore-aggregation

Conversation

@thijslemmens
Copy link
Contributor

@thijslemmens thijslemmens commented Jan 19, 2026

This is totally created by Zed Agent backed by Claude, I did not review it myself yet.

@thijslemmens thijslemmens requested a review from a team as a code owner January 19, 2026 09:24
@thijslemmens thijslemmens marked this pull request as draft January 19, 2026 09:25
@thijslemmens thijslemmens requested a review from Copilot January 19, 2026 09:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements support for multiple content stores by introducing a ContentStoreRegistry abstraction. The changes enable content references to include an optional store identifier, allowing content to be stored across different storage backends while maintaining backward compatibility with existing single-store implementations.

Changes:

  • Introduced ContentStoreRegistry interface and DefaultContentStoreRegistry implementation to manage multiple content stores
  • Enhanced ContentReference to support optional store IDs with parsing/serialization logic
  • Updated ContentApiImpl, DatamodelApiImpl, and related components to use the registry instead of direct ContentStore references

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ContentApiImplTest.java Updated test setup to use ContentStoreRegistry instead of direct ContentStore, with extensive code formatting changes
ContentUploadAttributeMapper.java Modified to use ContentStoreRegistry for writing content and store content references with store IDs
DatamodelApiImpl.java Replaced ContentStore dependency with ContentStoreRegistry throughout, with significant code reformatting
ContentApiImpl.java Updated to retrieve stores from registry based on content reference store IDs
ContentReference.java Converted from Lombok @Value to explicit implementation with store ID support and parsing logic
build.gradle Added test dependencies for the contentstore-api module
ContentGridDomainAutoConfiguration.java Added bean configuration for ContentStoreRegistry and updated wiring

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@thijslemmens thijslemmens force-pushed the contentstore-aggregation branch from ac20c99 to 3987af6 Compare January 19, 2026 09:32
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants