Open
Conversation
(cherry picked from commit fdd44ae)
… for alignment with latest conventions. Updated tests accordingly and added necessary dependencies in build files. (cherry picked from commit 621d868669ad1e6744912a6c0abdc3ab1d5da830)
|
NielsCW
reviewed
Feb 13, 2026
| internalPlatform platform(project(':thunx-dependencies')) | ||
|
|
||
| compileOnly 'org.projectlombok:lombok' | ||
| compileOnly 'org.jspecify:jspecify' |
Contributor
There was a problem hiding this comment.
This compileOnly dependency that is added everywhere is technically not needed for the spring boot 4 update.
| api platform("org.springframework.cloud:spring-cloud-dependencies:2025.0.0") | ||
| api platform("org.springframework.boot:spring-boot-dependencies:4.0.1") | ||
| api platform("org.springframework.cloud:spring-cloud-dependencies:2025.1.0") | ||
| api platform("org.testcontainers:testcontainers-bom:1.20.4") |
Contributor
There was a problem hiding this comment.
This line overwrites the testcontainers version set by spring-boot. testcontainers was updated to v2 in spring-boot 4. I think it should be relatively straightforward to remove this line and update the testcontainers v2 dependencies in all the build.gradle files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.