Add terminal and _meta capability support to initialize request - #15
Closed
timvisher-dd wants to merge 4 commits into
Closed
Add terminal and _meta capability support to initialize request#15timvisher-dd wants to merge 4 commits into
timvisher-dd wants to merge 4 commits into
Conversation
This was referenced Feb 26, 2026
Co-authored-by: Codex <codex@openai.com>
timvisher-dd
force-pushed
the
support-terminal-and-meta-caps
branch
from
March 14, 2026 16:46
2b8029d to
5f66c7f
Compare
timvisher-dd
marked this pull request as ready for review
March 14, 2026 21:01
Contributor
Author
|
This has been thoroughly battle tested at this point. Whether |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bin/test runs byte-compilation, ERT tests, and checks that README.org is updated when code changes. GitHub Actions CI mirrors this on every push and PR. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6 tasks
Contributor
Author
|
Closed by timvisher-dd#1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes xenodium/agent-shell#342
See that issue for the full problem description and perf measurements.
Checklist
Implementation
acp-make-initialize-requestgains two new optional keyword arguments::terminal-capability— boolean (or:false) controlling whetherterminalappears inclientCapabilities. When nil (the default) it is omitted entirely, preserving backward compatibility.:meta-capabilities— an alist sent under the_metakey inclientCapabilities. This is where clients advertise support for extensions liketerminal_output. When nil,_metais omitted.The existing
:read-text-file-capabilityand:write-text-file-capabilityarguments are unchanged.Example
Produces JSON with:
{ "clientCapabilities": { "fs": { "readTextFile": true, "writeTextFile": true }, "terminal": true, "_meta": { "terminal_output": true } } }Tests
4 new tests in
tests/acp-test.el:test-acp-make-initialize-request-omits-terminal-and-meta-when-nil— verifies backward compat: noterminalor_metakeys when args are nil.test-acp-make-initialize-request-terminal-true—terminal: truewhen:terminal-capability t.test-acp-make-initialize-request-terminal-false—terminal: falsewhen:terminal-capability :false.test-acp-make-initialize-request-meta-capabilities— arbitrary alist is passed through under_meta.