Fix failure handling of script_decomp.sh #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and Python3 because reasons, so that is kind of shit as well
- Fix counter - Add decompile attempt with Python 2 (successfully decompiles all personal decompilation failures)
Improve script_decomp.sh failure handling, among other things
- Eve Echoes has a filelist embedded in res0.npk which has a list of
all files along with their hash, which can be used to re-created the
original file tree
Breaking changes to the CLI interface:
- Output directory is now an option on the x (unpack) subcommand, -d
- Removed positional output directory argument, as we now support a
list of NPK files to unpack
The script started failing before copying the Python script to the correct directory, even if there was valid Python to be copied.
xforce
force-pushed
the
master
branch
2 times, most recently
from
e958fa3
to
0ee767f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script started failing before copying the Python script to the correct directory, even if there was partially valid Python.