Skip to content

improve iOS Modal slide-up, fade-in animation performance #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improve iOS Modal slide-up, fade-in animation performance #404

wants to merge 1 commit into from

Conversation

LSJJOON
Copy link

@LSJJOON LSJJOON commented Feb 14, 2020

  • change animation with height to translateY
  • attach fade-in animation

@LSJJOON
improve iOS Modal slide-up, fade-in animation performance
785cc87 
- change animation with height to translateY
- attach fade-in animation
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.368% when pulling 785cc87 on LSJJOON:dev_improve_iOS_anim_preformance into 2a209bd on xgfe:master.

@LSJJOON LSJJOON requested a review from feyy February 14, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feyy feyy Awaiting requested review from feyy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LSJJOON @coveralls