Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced DistributedObjectAdmin to compare for inconsistencies between instances #3851

Merged
merged 34 commits into from
Jan 5, 2025

Conversation

jskupsik
Copy link
Contributor

@jskupsik jskupsik commented Dec 12, 2024

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@jskupsik
Copy link
Contributor Author

Hoist-core PR: xh/hoist-core#426
No toolbox PR.

@lbwexler
Copy link
Member

I think the UI can be adjusted a bit to take better advantage of the space
how about we make the main tree grid narrow, allowing the wide instance grid to go to the right, with the instance detail below it?

Would also like to see a single button for "Clear All Hibernate Caches" in the top toolbar. The ability to clear individual hibernate caches can appear as a context menu item, only appearing if entire selection is made up of Hibernate caches

@lbwexler
Copy link
Member

lbwexler commented Jan 5, 2025

  • Broke out the detail panel from the main report panel, in order to just break this thing up a bit.
  • Made a number of additional UI tweaks and simplifications that we can go over tomorrow.
    cr: jakub (pending)

@lbwexler lbwexler merged commit ad6f08f into develop Jan 5, 2025
2 checks passed
@lbwexler lbwexler deleted the multiInstanceCompare branch January 5, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants