[FIX] get resource sale unit price from pricelist when get from default#43
Open
cialuo wants to merge 5 commits intoxie8899:business_requirement_deliverable_8.0from
Conversation
| def get_closest_ancestor_pricelist(self): | ||
| for project in self: | ||
| pricelist = self.env['product.pricelist'].browse( | ||
| project.pricelist_id.id) |
Collaborator
There was a problem hiding this comment.
not sure this is enough.
Rule should be for the pricelist:
If pricelist in master project then use project.pricelist
else if pricelist is project parent then use parent_project.pricelist
else use partner.pricelist
Author
There was a problem hiding this comment.
@elicoidal Seb told me that the rule had not been confirmed, So just let me keep the function and in other model can use this function.
|
Make sure that everywhere in the BR module(s), when you need the pricelist of a BR, you systematically use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[FIX] get resource sale unit price from pricelist when get from default
Rule should be for the pricelist:
If pricelist in master project then use project.pricelist
else if pricelist is project parent then use parent_project.pricelist
else use partner.pricelist
ifto use it in the condition. It should use get_estimation_pricelist (of the BR)`````` self.get_estimation_pricelist()```
br.get_estimation_pricelist()br.get_estimation_pricelist()br.get_estimation_pricelist()ifto use in the conditionbr.get_estimation_pricelist()