Add op_fclose to keep fclose's type signature the same #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: CFI indirect function call sanitization checks that function signatures at runtime match those that were determined at compile time. This fix ensures that fclose has the correct function signature when being passed a stream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem cropped up when I was trying to enable CFI-icall with Opusfile as a dependency. CFI indirect function call sanitization checks that function signatures at runtime match those that were determined at compile time. This fix ensures that
fclosehas the correct function signature when being passed a stream.I have a quick sample here on Godbolt: https://godbolt.org/z/EGsPYae51
An exit code of 132 is SIGILL which means a CFI violation was found and program execution was stopped.