security(github-dev-assistant): add dm-only scope to destructive tools - #68
Merged
Conversation
Adding .gitkeep for PR creation (default mode). This file will be removed when the task is complete. Issue: xlabtg#60
…s (issue xlabtg#60) Destructive tools (merge, push, close, delete, cancel) were missing scope: "dm-only", allowing them to be called in group chats. This patch adds the restriction to all 8 affected tools: - github_merge_pr - github_push_files - github_close_issue - github_reopen_issue - github_assign_issue - github_create_gist - github_delete_label - github_cancel_workflow_run Bumps plugin version to 3.1.2. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
konard
changed the title
konard
marked this pull request as ready for review
March 27, 2026 00:59
This reverts commit d2c632a.
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
🤖 Models used:
📎 Log file uploaded as Gist (1856KB)Now working session is ended, feel free to review and add any feedback on the solution draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #60
Destructive tools in
github-dev-assistantwere missingscope: "dm-only", allowing them to be invoked in group chats. This is a security risk — a user in a shared channel could accidentally (or maliciously) trigger irreversible operations like merging PRs, deleting labels, or cancelling CI runs.Changes
Added
scope: "dm-only"to 8 destructive/write tools:github_merge_prlib/pr-manager.jsgithub_push_fileslib/extended-repo-ops.jsgithub_close_issuelib/issue-tracker.jsgithub_reopen_issuelib/issue-pr-ops.jsgithub_assign_issuelib/issue-pr-ops.jsgithub_create_gistlib/user-social-ops.jsgithub_delete_labellib/label-ops.jsgithub_cancel_workflow_runlib/workflow-ops.jsTwo tools (
github_delete_file,github_download_file) already hadscope: "dm-only"correctly set.Plugin version bumped:
3.1.1→3.1.2.Validation
npm run validate—github-dev-assistant: 60 tool(s) validated✅npx eslint— 0 errors, pre-existing warning in unrelated test file ✅This PR was created automatically by the AI issue solver