-
Notifications
You must be signed in to change notification settings - Fork 22
IC profiler test refresh #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
25e623b to
d86dd3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modernizes the IC (Interference Canceller) profiler test infrastructure by refactoring tests to use a standardized run_dut utility, migrating from legacy xscope/xtagctl-based testing to a more flexible approach that supports both native and xs3a targets. The changes also include cleanup of deprecated example code and consolidation of build configurations.
- Standardized test execution through
run_dut.pywith support for multiple targets (native/xs3a) - Added utility function
interleave_channel_framesfor consistent data formatting across tests - Consolidated IC test build configurations into shared cmake files
Reviewed changes
Copilot reviewed 31 out of 34 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| test/shared/python/run_dut.py | Added get_binary_path() function to determine correct binary path based on target platform; updated run_dut() to accept target parameter |
| test/shared/python/py_vs_c_utils.py | Added interleave_channel_frames() utility function for converting multi-channel data into interleaved frame format |
| test/shared/config/ic_conf_no_adapt_control.json | Added input/output channel count configuration parameters |
| test/shared/config/ic_conf_big_delta.json | Added input/output channel count configuration parameters |
| test/lib_vnr/vnr_unit_tests/conftest.py | Migrated from 'x86'/'xcore' to 'native'/'xs3a' target naming; removed explicit path construction in favor of run_dut |
| test/lib_vnr/test_vnr_profile/test_vnr_profile.py | Replaced --run-x86 argument with --target for consistent target selection |
| test/lib_ic/test_wav_ic/plot_compare.py | Removed obsolete debug comparison script |
| test/lib_ic/test_wav_ic/config.xscope | Removed xscope configuration (moved to shared location) |
| test/lib_ic/test_wav_ic/CMakeLists.txt | Removed (functionality consolidated into shared cmake files) |
| test/lib_ic/test_ic_spec/test_ic_spec.py | Refactored to use run_dut instead of xscope_fileio/xtagctl; improved data handling with new utility functions |
| test/lib_ic/test_ic_spec/CMakeLists.txt | Simplified build configuration to reference shared IC test library |
| test/lib_ic/test_ic_profile/test_ic_profile.py | Refactored from xscope_fileio to run_dut; improved data interleaving and file handling |
| test/lib_ic/test_ic_profile/src/main.xc | Added xcore main entry point for IC profile test |
| test/lib_ic/test_ic_profile/src/ic_test_task.c | Added IC test task implementation for profiling |
| test/lib_ic/test_ic_profile/basic_ic_app.cmake | Created shared cmake library for IC test applications |
| test/lib_ic/test_ic_profile/CMakeLists.txt | Updated to use shared cmake library; consolidated profile processing flags |
| test/lib_ic/py_c_frame_compare/test_ic_frame.py | Updated input file path reference |
| test/lib_ic/characterise_c_py/test_polar_response.py | Simplified test by removing redundant test case; updated to use refactored functions |
| test/lib_ic/characterise_c_py/get_polar_response.py | Refactored to use new get_attenuation_c_py function; removed file-based approach |
| test/lib_ic/characterise_c_py/characterise_c_py.py | Major refactor to use run_dut instead of xscope_fileio; replaced file-based processing with in-memory data processing |
| test/lib_ic/characterise_c_py/CMakeLists.txt | Simplified build configuration to reference shared IC test library |
| test/lib_ic/CMakeLists.txt | Reorganized subdirectory inclusion; moved tests out of xcore-only conditional |
| modules/lib_ic/src/ic.c | Removed unused debug function declarations |
| examples/bare-metal/ic/src/ic_test_task.c | Removed (functionality moved to test directory) |
| examples/bare-metal/ic/src/dump_var_py.h | Removed obsolete debug utility header |
| examples/bare-metal/ic/src/dump_var_py.c | Removed obsolete debug utility implementation |
| examples/bare-metal/ic/README.rst | Removed (example deprecated) |
| examples/bare-metal/ic/CMakeLists.txt | Removed (example deprecated) |
| examples/bare-metal/doc/index.rst | Removed IC example from documentation index |
| examples/bare-metal/doc/ic.rst | Removed IC example documentation |
| examples/bare-metal/CMakeLists.txt | Removed IC example subdirectory |
| Jenkinsfile | Removed IC example execution; updated test comments and added verbose flag to ic_profile test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.