[wip] Feature/breaking changes for v2 #179
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2cc1b2a.
Allan-xmos
added
pr:nojenkins
… rename mute property to mute_state
…I, and rename saved_gain to user_gain
…_changes_for_v2 # Conflicts: # lib_audio_dsp/api/dsp/signal_chain.h # lib_audio_dsp/src/dsp/signal_chain.c
…rol_helpers # Conflicts: # lib_audio_dsp/src/control/signal_chain.c
Feature/volume_control_refactor
…_changes_for_v2 # Conflicts: # CHANGELOG.rst # python/audio_dsp/dsp/signal_chain.py # test/signal_chain/test_signal_chain_python.py
Allan-xmos
added
pr:nojenkins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR of breaking changes to merge before V2
dBwithdbin various APIssaved_gainwithuser_gain