Skip to content

Support the case where an output edge is none #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Allan-xmos merged 3 commits into from
Jan 8, 2026
+8 −6
Merged

Support the case where an output edge is none #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68b9aba
Support the case where an output edge is none
xhuw Sep 2, 2025
d00d785
Merge branch 'develop' into feature/support-none-edges
xhuw Jan 8, 2026
33c2ab2
Merge branch 'develop' into feature/support-none-edges
Allan-xmos Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions python/audio_dsp/design/parse_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,11 +315,12 @@ def pipeline_to_dspjson(pipeline) -> DspJson:

output_in = []
for x in pipeline.o.edges:
if x.source is not None:
output_in.append([f"{x.source.label}", x.source_index])
else:
# if the source is None, it means it's a direct input to the pipeline
output_in.append([f"inputs", x.source_index])
if x is not None:
if x.source is not None:
output_in.append([f"{x.source.label}", x.source_index])
else:
# if the source is None, it means it's a direct input to the pipeline
output_in.append([f"inputs", x.source_index])

outputs = [Output(name="outputs", input=output_in)]

Expand Down
3 changes: 2 additions & 1 deletion python/audio_dsp/design/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,8 @@ def set_outputs(self, output_edges: StageOutputList):
if len(self.o.edges) >= 1:
thread_crossings = []
for edge in output_edges.edges:
thread_crossings.append(len(set(edge.crossings))) # pyright: ignore checked above
if edge is not None:
thread_crossings.append(len(set(edge.crossings))) # pyright: ignore checked above

if not all(x == thread_crossings[0] for x in thread_crossings):
input_msg = "\n"
Expand Down