-
Notifications
You must be signed in to change notification settings - Fork 11
Adding dual ethernet 316 dev-kit #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding dual ethernet 316 dev-kit #66
Conversation
399cb74 to
09968f0
Compare
a6894ef to
58e0b87
Compare
d1951ec to
627416a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the new dual ethernet XK-ETH-316-DUAL development kit, implementing only the first PHY (ETH0) for now. The changes include board configuration files, PHY driver implementation, and necessary updates to version numbers and documentation.
Key changes:
- Addition of XK-ETH-316-DUAL board support with single PHY implementation
- Debug unit additions for selective debug output across ethernet boards
- Version bump from 1.3.0 to 1.4.0 across all configuration files
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| xn_files/xk-eth-316-dual.xn | New board configuration file defining ports and hardware layout for dual ethernet dev-kit |
| lib_board_support/src/boards/xk_eth_316_dual/xk_eth_316_dual.xc | New PHY driver implementation for DP83825I PHYs with MMD register access |
| lib_board_support/api/boards/xk_eth_316_dual/board.h | New API header defining board-specific functions and constants |
| lib_board_support/src/boards/xk_eth_xu316_dual_100m/xk_eth_xu316_dual_100m.xc | Code improvements including debug units, magic number defines, and MMD register fixes |
| settings.yml, module_build_info, lib_build_info.cmake | Version updates from 1.3.0 to 1.4.0 |
| lib_board_support/api/boards/boards_utils.h | Board enumeration updates to include new XK_ETH_316_DUAL |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lib_board_support/src/boards/xk_eth_316_dual/xk_eth_316_dual.xc
Outdated
Show resolved
Hide resolved
lib_board_support/src/boards/xk_eth_316_dual/xk_eth_316_dual.xc
Outdated
Show resolved
Hide resolved
627416a to
f935dcf
Compare
shuchitak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Hopefully we'll get more confidence that it works when we run lib_ethernet HW tests on this board.
lib_board_support/src/boards/xk_eth_316_dual/xk_eth_316_dual.xc
Outdated
Show resolved
Hide resolved
f935dcf to
b8c09f4
Compare
Adding debug units for selective output from this library
b8c09f4 to
fb95f4b
Compare
Adding support for new dual ethernet dev-kit. BUT, only first PHY for now. For reference these changes are built in lib_ethernet PR, xmos/lib_ethernet#182
Documentation update to follow this PR.
Please note, to complete port will need the following tasks to be completed on lib_ethernet,
Plus, updates to dual ethernet test board driver to fix issue of trying to access vendor specific register (0x302) without using MMD function. Added defines for magic numbers.
Also, added debug units to ethernet boards, for selective debug output.