Skip to content

Conversation

@humphrey-xmos
Copy link
Contributor

@humphrey-xmos humphrey-xmos commented Aug 4, 2025

Adding support for new dual ethernet dev-kit. BUT, only first PHY for now. For reference these changes are built in lib_ethernet PR, xmos/lib_ethernet#182

Documentation update to follow this PR.

Please note, to complete port will need the following tasks to be completed on lib_ethernet,

Plus, updates to dual ethernet test board driver to fix issue of trying to access vendor specific register (0x302) without using MMD function. Added defines for magic numbers.
Also, added debug units to ethernet boards, for selective debug output.

@humphrey-xmos humphrey-xmos force-pushed the adding-eth-audio-xu316 branch from 399cb74 to 09968f0 Compare August 8, 2025 15:35
@humphrey-xmos humphrey-xmos changed the title Adding dual ethernet audio xu316 dev-kit Adding dual ethernet 316 dev-kit Aug 8, 2025
@humphrey-xmos humphrey-xmos force-pushed the adding-eth-audio-xu316 branch 2 times, most recently from a6894ef to 58e0b87 Compare August 8, 2025 15:47
@humphrey-xmos humphrey-xmos force-pushed the adding-eth-audio-xu316 branch 3 times, most recently from d1951ec to 627416a Compare August 18, 2025 10:56
@humphrey-xmos humphrey-xmos requested a review from Copilot August 18, 2025 11:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the new dual ethernet XK-ETH-316-DUAL development kit, implementing only the first PHY (ETH0) for now. The changes include board configuration files, PHY driver implementation, and necessary updates to version numbers and documentation.

Key changes:

  • Addition of XK-ETH-316-DUAL board support with single PHY implementation
  • Debug unit additions for selective debug output across ethernet boards
  • Version bump from 1.3.0 to 1.4.0 across all configuration files

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
xn_files/xk-eth-316-dual.xn New board configuration file defining ports and hardware layout for dual ethernet dev-kit
lib_board_support/src/boards/xk_eth_316_dual/xk_eth_316_dual.xc New PHY driver implementation for DP83825I PHYs with MMD register access
lib_board_support/api/boards/xk_eth_316_dual/board.h New API header defining board-specific functions and constants
lib_board_support/src/boards/xk_eth_xu316_dual_100m/xk_eth_xu316_dual_100m.xc Code improvements including debug units, magic number defines, and MMD register fixes
settings.yml, module_build_info, lib_build_info.cmake Version updates from 1.3.0 to 1.4.0
lib_board_support/api/boards/boards_utils.h Board enumeration updates to include new XK_ETH_316_DUAL

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@shuchitak shuchitak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Hopefully we'll get more confidence that it works when we run lib_ethernet HW tests on this board.

@humphrey-xmos humphrey-xmos force-pushed the adding-eth-audio-xu316 branch from f935dcf to b8c09f4 Compare August 18, 2025 15:55
Adding debug units for selective output from this library
@humphrey-xmos humphrey-xmos force-pushed the adding-eth-audio-xu316 branch from b8c09f4 to fb95f4b Compare August 19, 2025 09:14
@humphrey-xmos humphrey-xmos merged commit 1fcfad5 into xmos:develop Aug 19, 2025
2 checks passed
@humphrey-xmos humphrey-xmos deleted the adding-eth-audio-xu316 branch August 19, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants