Skip to content

Replaced xc by c, removed print.h, added pytest #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mbanth merged 6 commits into from
Jan 12, 2026
Merged

Replaced xc by c, removed print.h, added pytest #87

mbanth merged 6 commits into from
Jan 12, 2026

Conversation

@xalbertoisorna
Copy link
Contributor

@xalbertoisorna xalbertoisorna commented Jan 12, 2026 •
edited
Loading

  • Removed unused <print.h> header.
  • Replaced ".xc" files with ".c" files.
  • Updated tests to use Pytest framework and xsim.

@xalbertoisorna
Update changelog, enhance tests, and refactor code
bf6dcdf 
- Updated CHANGELOG with recent changes.
- Refactored tests to utilize Pytest framework.
- Added new example applications for debug printing.
- Removed unused header and replaced file extensions.
@xalbertoisorna
copyright update
8006146
@xalbertoisorna
Update example file extensions from .xc to .c in documentation
9f5a42a
@xalbertoisorna xalbertoisorna marked this pull request as ready for review January 12, 2026 09:56
@xalbertoisorna xalbertoisorna changed the title Update changelog, enhance tests, and refactor code Update changelog, enhance tests, and updated xc to c Jan 12, 2026
@xalbertoisorna xalbertoisorna changed the title Update changelog, enhance tests, and updated xc to c Updated xc to c, removed print.h, added pytest Jan 12, 2026
@mbanth mbanth requested review from mbanth and xross January 12, 2026 10:21
@xalbertoisorna xalbertoisorna changed the title Updated xc to c, removed print.h, added pytest Replaced xc by c, removed print.h, added pytest Jan 12, 2026
mbanth
mbanth approved these changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@mbanth mbanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. However, please wait for @xross to approve before merging.

@mbanth
Copy link
Contributor

mbanth commented Jan 12, 2026

A few additional comments:

  • Which architecture does xsim use when testing, XS3 or VX4? Can test_lib_logging.py be written in a way to test both?
  • At a cursory level, it looks like this PR replaces PR Remove unused include file #22 which has been open since 2019.
  • The current Jenkins job failed due to not finding a virtual environment.

@xalbertoisorna
Copy link
Contributor Author

xalbertoisorna commented Jan 12, 2026 •
edited
Loading

A few additional comments:

  • Which architecture does xsim use when testing, XS3 or VX4? Can test_lib_logging.py be written in a way to test both?
  • This is a good point, for now it depends on jenkins, so is using xs3.
  • This one can be partially closed. The new features need review. My proposal is to close it with a Jira backlog issue in LSM. Let me know your toughts.
  • The current Jenkins job failed due to not finding a virtual environment.
  • Solved now.

@xalbertoisorna xalbertoisorna requested a review from mbanth January 12, 2026 11:28
mbanth
mbanth reviewed Jan 12, 2026
View reviewed changes
Copy link
Contributor

@mbanth mbanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Please wait for approval by @xross before merging.

xross
xross approved these changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@xross xross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, updates to xmosdoc and infr_apps versions would be the cherry on the cake.

@xross
Copy link
Contributor

xross commented Jan 12, 2026

  • This is a good point, for now it depends on jenkins, so is using xs3.

Test is built for XS3 - uses an XS3 XN file.

@mbanth mbanth merged commit 2dcb64c into xmos:develop Jan 12, 2026
2 checks passed
@xalbertoisorna xalbertoisorna deleted the feature/vx4 branch January 12, 2026 14:11
@xalbertoisorna xalbertoisorna mentioned this pull request Jan 12, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbanth mbanth mbanth approved these changes

@xross xross xross approved these changes

Assignees

@xalbertoisorna xalbertoisorna

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xalbertoisorna @mbanth @xross