Skip to content

Conversation

@larry-xmos
Copy link
Contributor

Saves one channel end in endpoint 0 thread

Copy link
Contributor

@xross xross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd version no?

@xross
Copy link
Contributor

xross commented Jan 10, 2019

Hi Larry, why does this save a chan-end? Because the compiler only does one getr for the used end? Do you not get a build warning about only passing the channel to one core?

@xross
Copy link
Contributor

xross commented Jan 10, 2019

Resolved conflicts

@larry-xmos
Copy link
Contributor Author

Odd version no?

Yes, it's based on version 0.1.0 that comes with VocalFusion 2.2.2. The PR was meant as a placeholder, and it might make most sense to redo it (which I would hope to be able to do soon).

Furthermore, main XUD thread uses an extra channel end the same way, but in multiple places, making it difficult to hoist out.

@xross
Copy link
Contributor

xross commented Jan 10, 2019

Okay, thanks

@larry-xmos
Copy link
Contributor Author

@ross, is there any chance you will be using this soon? If yes, I would consider bringing it up to date. Or is it best closed?

@xross
Copy link
Contributor

xross commented Jun 17, 2020

Hi Larry, this looks like useful work, I'd like to keep it open until I (or someone else) has time to review.

@larry-xmos
Copy link
Contributor Author

larry-xmos commented Jun 17, 2020

I'd like to keep it open until I (or someone else) has time to review

OK, I'd always wanted to come back and look for a way to reduce the number of functions that have to change without using a global variable

@mbanth
Copy link
Contributor

mbanth commented Jun 17, 2020

Given @larry-xmos schedule, it would be good to have a decision by 1 July, both for this PR and for lib_xua PR-77. That way he has time to bring them up-to-date if we decide to merge them in.

@xross
Copy link
Contributor

xross commented Jun 17, 2020

Note, this is probably not relevant for XS3 since we no longer store a device address in HW. I believe all accesses to HW are now from the XUD core.

@larry-xmos
Copy link
Contributor Author

On the basis that Phoenix no longer has to do the Set Address calls, I close this item

@larry-xmos larry-xmos closed this Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants