Skip to content
This repository was archived by the owner on Mar 26, 2025. It is now read-only.

Conversation

anki-code
Copy link
Member

This PR is the result of merging current versions of xonsh/xonsh/completers/bash_completion.py and py-bash-completion/bash_completion.py.

@anki-code anki-code requested a review from gforsyth March 24, 2025 10:08
@anki-code
Copy link
Member Author

Hi @gforsyth!
I've merged two versions of one file and to avoid this mess in the future I suggest to remove/archive this repository with moving the result code to xonsh/completers/bash_completion.py.
If we want to have this distinct repo please describe why. I suppose we wanted to provide this functionality as a library but in this case we need to create a xontrib with package and add it to xonsh repository as dependency - this looks like the right way. So let's do either removing/archiving it or create a xontrib and remove it from xonsh repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant