Add MANIFEST.in file to fix source distribution#16
Merged
st3107 merged 1 commit intoxpdAcq:masterfrom Mar 2, 2021
Merged
Conversation
Contributor
|
We package it with conda from https://github.com/nsls-ii-forge/xpdconf-feedstock/blob/9ebbb818124aa8f817d2fda8408261783e7ac6f0/recipe/meta.yaml#L9, and that uploaded artifact is missing the examples .yaml files. |
Contributor
|
@st3107, will you be able to review/merge it and cut a new release after the fix? We would like to have our |
Collaborator
|
Thank you for the fix. |
This was referenced Mar 2, 2021
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
We were updating CI for the NSLS-II PDF
profile_collectionrepo and discovered an issue:See this link for more details:
NSLS2/pdf-profile-collection#24
This pull request adds a missing MANIFEST.in file which is required to include non-Python files in the source distribution (.tar.gz file). We also made the
xpdConf/testsdirectory a library to make it part of the source and binary distribution.Before the fix:
After the fix: