Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to skip installtion #972

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

ToKiNoBug
Copy link
Contributor

@ToKiNoBug ToKiNoBug commented Nov 12, 2023

An option XSIMD_SKIP_INSTALL is added to decide whether to install xsimd files. This can be useful when xsimd is used as an subproject.

To keep default behavior unchanged, the default value of this option is OFF. Developers can set XSIMD_SKIP_INSTALL to ON in order to skip xsimd installtion.

This pr implements #959

@@ -44,3 +44,6 @@ docs/build/
# VSCode / clangd IntelliSense
.vscode/
.cache/

# CLion / IDEA
.idea/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in a local gitignore rather than in that of the project. However, we already have other settings for vscode, let's clean this in a dedicated PR.

@JohanMabille
Copy link
Member

Thanks for your PR!

@JohanMabille JohanMabille merged commit 69a23ab into xtensor-stack:master Nov 29, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants