-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various problems with architecture version handling #987
Conversation
a3ddd47
to
254a839
Compare
@JohanMabille : I think I unveiled a serious issue there: due to bad ordering of the version, wasm was never selected as a the default arch when available, which in turns nullify most of its test (intel arch was tested instead!) It's good that I caught this, but it's going to have some impact... |
4df0d0e
to
5660ec3
Compare
I think we don't have fallback implementation for all operations, therefore we cannot add new instruction sets and registers if we don't implement a minimal subset. What I don't understand is that when Anutosh was implementing the support for WASM, the build was failing until he had implemented the minimal subset; so WASM was selected at some point. Also this explains why removing the workaround Thorsten implemented for arg / conj did not make the tests fail: at this point, we were in this configuration, where WASM was not selected anymore. |
Yes I believe there was a minimalistic subset of operations. After I had implemented all of those, the build stopped failing. |
6aa4137
to
b3fec3f
Compare
Some architectures were not registered in the `xsimd::all_architectures` arch list. The test for issorted was incorrect. Some architectures add wrong version values but this went unnoticed because of the invalid check.
3280390
to
9d2860e
Compare
Thanks @serge-sans-paille! It is looking like it is going to be in working order with wasm. |
9d2860e
to
a3d08da
Compare
@SylvainCorlay yep, wasm fixed, I'm handling the final touches and this should be mergeable. @JohanMabille this deserves a minor release (patch + new features) |
a3d08da
to
917d690
Compare
917d690
to
c153824
Compare
The actual hierarchy is avx512-vbmi avx512-ifma avx512-bw avx512-dq avx512-vl avx512-f avx512-cd for cannonlake <- skylake and avx512-er avx512-pf avx512-f avx512-cd for kights landing
\o/ hurray, that one was a tough one! |
Some architectures were not registered in the
xsimd::all_architectures
arch list.The test for issorted was incorrect.
Some architectures add wrong version values but this went unnoticed because of the invalid check.