[StarRocks#367][BugFix]enhance unqualified load-url config validate a…

…nd test Signed-off-by: jam.xu <[email protected]>
xumanbu · Jun 21, 2024 · ad41f30 · ad41f30
1 parent cc8689d
commit ad41f30
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/main/java/com/starrocks/connector/flink/table/sink/StarRocksSinkOptions.java b/src/main/java/com/starrocks/connector/flink/table/sink/StarRocksSinkOptions.java
@@ -380,7 +380,7 @@ public boolean isUseUnifiedSinkApi() {
     private void validateStreamLoadUrl() {
         tableOptions.getOptional(LOAD_URL).ifPresent(urlList -> {
             for (String host : urlList) {
-                if (host.split(":").length < 2) {
+                if (host.split(":").length != 2) {
                     throw new ValidationException(String.format(
                             "Could not parse host '%s' in option '%s'. It should follow the format 'host_name:port'.",
                             host,

diff --git a/...cks-stream-load-sdk/src/main/java/com/starrocks/data/load/stream/DefaultStreamLoader.java b/...cks-stream-load-sdk/src/main/java/com/starrocks/data/load/stream/DefaultStreamLoader.java
@@ -45,6 +45,7 @@
 
 import java.io.Serializable;
 import java.net.HttpURLConnection;
+import java.net.MalformedURLException;
 import java.net.URL;
 import java.util.Collections;
 import java.util.HashMap;
@@ -388,6 +389,8 @@ private boolean testHttpConnection(String host) {
             connection.connect();
             connection.disconnect();
             return true;
+        } catch (MalformedURLException e) {
+            throw new IllegalArgumentException("Illegal stream load url config, please check config value.", e);
         } catch (Exception e) {
             log.warn("Failed to connect to address:{}", host, e);
             return false;