Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat trigger x1010 when InlineData is negative int and parameter is uint #189

Closed
wants to merge 9 commits into from

Conversation

NormanFrieman
Copy link
Contributor

When pass negative int in inlinedata and the parameter of test is uint, the test will fail in runtime

@NormanFrieman
Copy link
Contributor Author

@dotnet-policy-service agree

@bradwilson
Copy link
Member

Sorry for the delay, I thought I had already left a comment here but I must not have submitted it. ☹️

The fix provided here is very focused on specifically negative ints and uints. An ideal fix would be generalized to support all integral types, ensuring compatibility.

@bradwilson
Copy link
Member

Thanks! I needed to fix some merge issues and wanted to add an edge case to the tests, but your branch is not open to pushes, so I had to do them myself. You're credited with the squashed commit: d25b3a4

@bradwilson bradwilson closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants