Merged
Conversation
kidunot89
force-pushed
the
tests/posts-connector
branch
from
b3d65fb to
b5dd19e
Compare
kidunot89
force-pushed
the
tests/posts-connector
branch
from
9e0f058 to
62c6d36
Compare
kidunot89
force-pushed
the
tests/posts-connector
branch
from
62c6d36 to
42bfceb
Compare
dero
suggested changes
Sep 14, 2020
Contributor
dero
left a comment
dero
left a comment
There was a problem hiding this comment.
@kidunot89 Good progress here! Added a few comments and a question. May have also potentially found a bug in Stream, but want to confirm with you first as I'm new to the codebase.
kidunot89
force-pushed
the
tests/posts-connector
branch
from
42bfceb to
c1622e9
Compare
Contributor
Author
|
@dero All requested changes have been made. Please review this again. |
kidunot89
commented
Sep 24, 2020
| } | ||
|
|
||
| if ( 'auto-draft' === $old && 'auto-draft' !== $new ) { | ||
| if ( in_array( $old, $start_statuses, true ) && ! in_array( $new, $start_statuses, true ) ) { |
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
I've also update the tests to confirm that changes 👍
dero
approved these changes
Sep 30, 2020
| } | ||
|
|
||
| if ( 'auto-draft' === $old && 'auto-draft' !== $new ) { | ||
| if ( in_array( $old, $start_statuses, true ) && ! in_array( $new, $start_statuses, true ) ) { |
Contributor
|
Was this change related to this failing unit test? https://travis-ci.com/github/xwp/stream/jobs/393230336#L512 I wonder why the Travis checks didn't run for this pull request. |
Contributor
Author
|
No, but it's small issue, I'll fix it another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #1093
Summary checklist
transition_post_statuscallback testdeleted_postcallback test