Description
Remove unnecessary rvalue reference parameters (&&) from private constructors as they don't provide meaningful benefits for internal-only APIs.
Context
During PR review, it was noted that private constructors don't need the flexibility of rvalue references since they are only used internally. This applies to parameters like stream_reader_data_context in private constructors.
Examples
UnstructuredIrStreamReader private constructor
StructuredIrStreamReader private constructor (if applicable)
- Other similar cases in the codebase
References
Acceptance Criteria
Requested by: @junhaoliao
Description
Remove unnecessary rvalue reference parameters (
&&) from private constructors as they don't provide meaningful benefits for internal-only APIs.Context
During PR review, it was noted that private constructors don't need the flexibility of rvalue references since they are only used internally. This applies to parameters like
stream_reader_data_contextin private constructors.Examples
UnstructuredIrStreamReaderprivate constructorStructuredIrStreamReaderprivate constructor (if applicable)References
Acceptance Criteria
&&from private constructor parameters where not neededRequested by: @junhaoliao