Skip to content

Remove unnecessary rvalue references from private constructors #90

Description

@coderabbitai

Description

Remove unnecessary rvalue reference parameters (&&) from private constructors as they don't provide meaningful benefits for internal-only APIs.

Context

During PR review, it was noted that private constructors don't need the flexibility of rvalue references since they are only used internally. This applies to parameters like stream_reader_data_context in private constructors.

Examples

  • UnstructuredIrStreamReader private constructor
  • StructuredIrStreamReader private constructor (if applicable)
  • Other similar cases in the codebase

References

Acceptance Criteria

  • Identify all private constructors using rvalue references unnecessarily
  • Remove && from private constructor parameters where not needed
  • Ensure all call sites still compile and work correctly
  • Update any related documentation if necessary

Requested by: @junhaoliao

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions