haiqi review

y-scope · Feb 6, 2025 · 0628636 · 0628636
1 parent 920cfb8
commit 0628636
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/components/core/src/clp/streaming_archive/writer/Archive.cpp b/components/core/src/clp/streaming_archive/writer/Archive.cpp
@@ -593,6 +593,9 @@ void Archive::close_segment_and_persist_file_metadata(
 
     for (auto file : files) {
         file->mark_as_in_committed_segment();
+        // Files in this collection only hold metadata. Emplaced files have called method
+        // `File::append_to_segment()` which deallocates memory for timestamp,
+        // logtype, and variable fields.
         m_file_metadata_for_global_update.emplace_back(file);
     }
 

diff --git a/components/core/src/clp/streaming_archive/writer/Archive.hpp b/components/core/src/clp/streaming_archive/writer/Archive.hpp
@@ -321,9 +321,6 @@ class Archive {
     std::vector<File*> m_files_with_timestamps_in_segment;
     std::vector<File*> m_files_without_timestamps_in_segment;
 
-    // Files in this collection only hold metadata. Files are added to this collection after
-    // `File::append_to_segment()` is called, which deallocates memory for timestamp,
-    // logtype, and variable fields.
     std::vector<File*> m_file_metadata_for_global_update;
 
     size_t m_target_segment_uncompressed_size;